More ldap failure checks

librenms · Jun 18, 2024 · bdfdd7e · bdfdd7e
1 parent c202b65
commit bdfdd7e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/LibreNMS/Authentication/ADAuthorizationAuthorizer.php b/LibreNMS/Authentication/ADAuthorizationAuthorizer.php
@@ -78,6 +78,9 @@ public function userExists($username, $throw_exception = false)
             $this->userFilter($username),
             ['samaccountname']
         );
+        if ($search === false) {
+            throw new AuthenticationException('User search failed: ' . ldap_error($this->ldap_connection));
+        }
         $entries = ldap_get_entries($this->ldap_connection, $search);
 
         if ($entries['count']) {
@@ -151,6 +154,9 @@ public function getUserid($username)
             $this->userFilter($username),
             $attributes
         );
+        if ($search === false) {
+            throw new AuthenticationException('Role search failed: ' . ldap_error($this->ldap_connection));
+        }
         $entries = ldap_get_entries($this->ldap_connection, $search);
 
         if ($entries['count']) {

diff --git a/LibreNMS/Authentication/LdapAuthorizationAuthorizer.php b/LibreNMS/Authentication/LdapAuthorizationAuthorizer.php
@@ -95,6 +95,9 @@ public function userExists($username, $throw_exception = false)
 
         $filter = '(' . Config::get('auth_ldap_prefix') . $username . ')';
         $search = ldap_search($this->ldap_connection, trim(Config::get('auth_ldap_suffix'), ','), $filter);
+        if ($search === false) {
+            throw new AuthenticationException('User search failed: ' . ldap_error($this->ldap_connection));
+        }
         $entries = ldap_get_entries($this->ldap_connection, $search);
         if ($entries['count']) {
             /*