Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert Transports page doesn't load after upgrade to 24.1.0-5 #15716

Closed
vhuk opened this issue Jan 9, 2024 · 7 comments
Closed

Alert Transports page doesn't load after upgrade to 24.1.0-5 #15716

vhuk opened this issue Jan 9, 2024 · 7 comments

Comments

@vhuk
Copy link
Contributor

vhuk commented Jan 9, 2024

The problem

Alert Transport page fails to load after upgrading to version 24.1.0-5-g2a7892b4c - Mon Jan 08 2024 20:49:57 GMT+0200. This is caused by error:

Class "LibreNMS\Alert\Transport\Jiraservicemanagement" not found {"userId":39,"exception":"[object] (Error(code: 0): Class "LibreNMS\Alert\Transport\Jiraservicemanagement" not found at /opt/librenms/LibreNMS/Alert/Transport.php:35)"}

Output of ./validate.php

===========================================
Component | Version
--------- | -------
LibreNMS  | 24.1.0-5-g2a7892b4c (2024-01-08T20:49:57+02:00)
DB Schema | 2023_12_10_130000_historical_data_to_ports_nac (277)
PHP       | 8.2.7
Python    | 3.11.2
Database  | MariaDB 10.11.4-MariaDB-1~deb12u1
RRDTool   | 1.7.2
SNMP      | 5.9.3
===========================================

[OK]    Composer Version: 2.6.6
[OK]    Dependencies up-to-date.
[OK]    Database connection successful
[OK]    Database Schema is current
[OK]    SQL Server meets minimum requirements
[OK]    lower_case_table_names is enabled
[OK]    MySQL engine is optimal
[OK]    Database and column collations are correct
[OK]    Database schema correct
[OK]    MySQl and PHP time match
[OK]    Active pollers found
[OK]    Dispatcher Service not detected
[OK]    Locks are functional
[OK]    Python poller wrapper is polling
[OK]    Redis is functional
[OK]    rrd_dir is writable
[OK]    rrdtool version ok

What was the last working version of LibreNMS?

24.1.0

Anything in the logs that might be useful for us?

Class "LibreNMS\Alert\Transport\Jiraservicemanagement" not found {"userId":39,"exception":"[object] (Error(code: 0): Class \"LibreNMS\\Alert\\Transport\\Jiraservicemanagement\" not found at /opt/librenms/LibreNMS/Alert/Transport.php:35)"}
@librenms-bot
Copy link

This issue has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/afer-version-24-1-0-2-cant-load-alert-rule-and-alert-transport/23285/3

@vhuk
Copy link
Contributor Author

vhuk commented Jan 9, 2024

This seems to be due to naming: class name is "JiraServiceManagement" and it is in file "JiraServiceManagement.php".

File that attempts to load the class (LibreNMS/Alert/Transport.php) will run the filename through strtolower() on L33 and ucfirst() on L138.

gil-obradors added a commit to gil-obradors/librenms that referenced this issue Jan 9, 2024
librenms#15716 Filenames must not be PascalCase, only the first letter can be uppercase.
PipoCanaja pushed a commit that referenced this issue Jan 9, 2024
* Rename JiraServiceManagement.php to Jiraservicemanagement.php

#15716 Filenames must not be PascalCase, only the first letter can be uppercase.

* Update Jiraservicemanagement.php

Following class name conventions

* Update Jiraservicemanagement.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
@PipoCanaja
Copy link
Contributor

PipoCanaja commented Jan 9, 2024

Hi @vhuk
Is it fixed on your setup after #15717 ?

@librenms-bot
Copy link

This issue has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/error-in-creating-alert-transport/23293/2

@librenms-bot
Copy link

This issue has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/afer-version-24-1-0-2-cant-load-alert-rule-and-alert-transport/23285/7

@vhuk
Copy link
Contributor Author

vhuk commented Jan 9, 2024

@PipoCanaja, This has been fixed by #15717. Thank you all!

@vhuk vhuk closed this as completed Jan 9, 2024
@dejantep
Copy link
Contributor

dejantep commented Jan 9, 2024

It's all good after running ./daily.sh manually
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants