You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In is_port_valid, the ifDescr value is lowercased initially and then checked against the bad_if array with strstr, meaning that the bad_if array contents must be lowercase as well, which is not documented. I think it would be simpler to remove the strtolower and use stristr instead of strstr. The same seems to make sense for bad_iftype, which currently checks without any transformation. The regexp method already appends 'i' to the regex. If the change is not accepted, then the documentation should indicate only lowercase values should be provided in the bad_if list.
The text was updated successfully, but these errors were encountered:
In is_port_valid, the ifDescr value is lowercased initially and then checked against the bad_if array with strstr, meaning that the bad_if array contents must be lowercase as well, which is not documented. I think it would be simpler to remove the strtolower and use stristr instead of strstr. The same seems to make sense for bad_iftype, which currently checks without any transformation. The regexp method already appends 'i' to the regex. If the change is not accepted, then the documentation should indicate only lowercase values should be provided in the bad_if list.
The text was updated successfully, but these errors were encountered: