Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_port_valid case sensitivity #2223

Closed
ciscoqid opened this issue Oct 27, 2015 · 1 comment
Closed

is_port_valid case sensitivity #2223

ciscoqid opened this issue Oct 27, 2015 · 1 comment

Comments

@ciscoqid
Copy link
Contributor

In is_port_valid, the ifDescr value is lowercased initially and then checked against the bad_if array with strstr, meaning that the bad_if array contents must be lowercase as well, which is not documented. I think it would be simpler to remove the strtolower and use stristr instead of strstr. The same seems to make sense for bad_iftype, which currently checks without any transformation. The regexp method already appends 'i' to the regex. If the change is not accepted, then the documentation should indicate only lowercase values should be provided in the bad_if list.

@laf
Copy link
Member

laf commented Oct 28, 2015

Sounds like a good idea :)

Is this something you can contribute?

@lock lock bot locked as resolved and limited conversation to collaborators May 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants