Added ability to force devices to use ifEntry instead of ifXEntry #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-Deploy finished, Test PR at http://4100.ci.librenms.org or https://4100.ci.librenms.org |
|
bump |
|
Thoughts? |
|
I'm good with this. |
|
Hi @laf, I have tried this PR in my test install and it works. |
|
@breeman1 and you get graphs? |
|
Yes I do:) |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note
Fix #4025
Not sure if this is the best approach to take here but basically some devices don't always output the info we need in ifXEntry for various interfaces so it's difficult for us to check we have complete data. Falling back to ifEntry seems the best approach for those devices.
The alternative would be to poll both ifXEntry and ifEntry as we did before but that would slow polling down for these devices.