Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support for avaya-vsp and fix problem in functions.php for avaya-vsp #4237

Merged
merged 27 commits into from
Aug 29, 2016
Merged

Update support for avaya-vsp and fix problem in functions.php for avaya-vsp #4237

merged 27 commits into from
Aug 29, 2016

Conversation

ospfbgp
Copy link
Contributor

@ospfbgp ospfbgp commented Aug 28, 2016

Please note

Please read this information carefully.

Added to allow Avaya VSP switches to discover its ports. All the Avaya VSP switches contain "Avaya Virtual Services Platform" in the port ifDescr and so you can not graph the ports with the current code.

Added to allow Avaya VSP switches to discover its ports.  All the Avaya VSP switches contain "Avaya Virtual Services Platform" in the port ifDescr and so you can not graph the ports with the current code.
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

Better description of the actual operating system on an Avaya VSP
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

add more support for sysObjectID for avaya-vsp
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

add more support for better information on an avaya-vsp switch
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

changed from using the current cpu to 5 minute average since librenms polls on a 5 minute average
create polling for cpu on avaya-vsp
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@laf
Copy link
Member

laf commented Aug 28, 2016

Will check through but yes this is how we wanted it :)

add support for correct memory utilization on avaya-vsp
support for polling of avaya-vsp memory
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@ospfbgp
Copy link
Contributor Author

ospfbgp commented Aug 28, 2016

I have updated all the files and put this in 1 pull request. thanks for the patience I am new to github and librenms.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@ospfbgp ospfbgp changed the title Update functions.php update support for avaya-vsp and fix problem in functions.php for avaya-vsp Aug 28, 2016
@ospfbgp ospfbgp changed the title update support for avaya-vsp and fix problem in functions.php for avaya-vsp Update support for avaya-vsp and fix problem in functions.php for avaya-vsp Aug 28, 2016
@@ -1019,7 +1019,7 @@
$config['os'][$os]['icon'] = 'avaya';

$os = 'avaya-vsp';
$config['os'][$os]['text'] = 'Avaya VSP';
$config['os'][$os]['text'] = 'VOSS';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this is changed to VOSS? It's only a text description and Avaya VSP seems more relevant still.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

How about Avaya VOSS?  VOSS is what Avaya calls the operating system on the VSP product.   I was trying to be very good description.  In my testing VOSS looked really nice in the webui.   Within Avaya the OS is called VOSS.

I know other definitions were 
$config['os'][$os]['text']             = 'ArubaOS';
$config['os'][$os]['text'] = 'PanOS';
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

Had a mistake should be sysObjectId not sysObjectID.
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

more testing revealed that I needed the add .0 to oid name
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

1 similar comment
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

no need for determining the os since it is a poller
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

more mistakes revealed with my multiplication of values
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

1 similar comment
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

2 similar comments
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://4237.ci.librenms.org or https://4237.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@ospfbgp
Copy link
Contributor Author

ospfbgp commented Aug 29, 2016

This is close to being ready. I am going to double check everything. My testing revealed a few issues but now things seem to be working properly on my test vsp switches with discovery and polling. I would like to call the operating system Avaya VOSS or VOSS in the definitions.inc.php. Here are some screen shots of what it looks like with Avaya VOSS.
screen1_voss
screen2_voss

@laf laf removed the Blocker 🚫 label Aug 29, 2016
@laf laf merged commit d62f2f9 into librenms:master Aug 29, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants