Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Strip out " returned from Proxmox application #4908 #5003

Merged
merged 2 commits into from Nov 21, 2016

Conversation

laf
Copy link
Member

@laf laf commented Nov 15, 2016

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Fixes #4908

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://5003.ci.librenms.org or https://5003.ci.librenms.org

@laf
Copy link
Member Author

laf commented Nov 20, 2016

bump

@@ -64,6 +64,7 @@ function proxmox_vm_exists($i, $c, &$pmxcache)
$pmxcache = array();

foreach ($pmxlines as $vm) {
$vm = preg_replace('/"/', '', $vm);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just str_replace?

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://5003.ci.librenms.org or https://5003.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@murrant murrant merged commit 63569b5 into librenms:master Nov 21, 2016
@laf laf deleted the issue-4908 branch November 21, 2016 18:09
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants