Update APC Humidity sensor #5325

Closed
NerdBlender opened this Issue Jan 6, 2017 · 1 comment

Projects

None yet

3 participants

@NerdBlender
Contributor
NerdBlender commented Jan 6, 2017 edited

DO NOT DELETE THIS INFORMATION.

Please read this information carefully.

GitHub issues is for feature requests or bugs, please do not post issues asking for help or how to do X, Y or Z.
You can use our irc channel ##librenms on freenode to ask questions or our community site.

  • Is your install up to date? Updating your install
    Please do not submit an issue if your install is not up to date within the last 24 hours or on a stable monthly release.
  • Please include all of the information between the ==================================== section of ./validate.php.
  • If you would like us to add a new device or your device is listed as Generic then please provide the information asked for here
  • Please provide as much detail as possible.

Would it be sensible to assume that if the APC humidity sensor is reading -1, then there is no humidity sensor attached? Happy to create a PR for this if it seems a sensible assumption.

@laf
Member
laf commented Jan 6, 2017

I'd say so yes, if -1 isn't a valid value then we should skip discovery of that sensor.

Most of the ones I add now all check for values of 0 or GT.

@laf laf added the Bug label Jan 6, 2017
@NerdBlender NerdBlender added a commit to NerdBlender/librenms that referenced this issue Jan 10, 2017
@NerdBlender NerdBlender Fixes APC -1 Humidity Sensor Value #5325 8216dd4
@Rosiak Rosiak closed this Jan 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment