Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APC Humidity sensor #5325

Closed
4 tasks done
NerdBlender opened this issue Jan 6, 2017 · 2 comments
Closed
4 tasks done

Update APC Humidity sensor #5325

NerdBlender opened this issue Jan 6, 2017 · 2 comments

Comments

@NerdBlender
Copy link
Contributor

NerdBlender commented Jan 6, 2017

DO NOT DELETE THIS INFORMATION.

Please read this information carefully.

GitHub issues is for feature requests or bugs, please do not post issues asking for help or how to do X, Y or Z.
You can use our irc channel ##librenms on freenode to ask questions or our community site.

  • Is your install up to date? Updating your install
    Please do not submit an issue if your install is not up to date within the last 24 hours or on a stable monthly release.
  • Please include all of the information between the ==================================== section of ./validate.php.
  • If you would like us to add a new device or your device is listed as Generic then please provide the information asked for here
  • Please provide as much detail as possible.

Would it be sensible to assume that if the APC humidity sensor is reading -1, then there is no humidity sensor attached? Happy to create a PR for this if it seems a sensible assumption.

@laf
Copy link
Member

laf commented Jan 6, 2017

I'd say so yes, if -1 isn't a valid value then we should skip discovery of that sensor.

Most of the ones I add now all check for values of 0 or GT.

@lock
Copy link

lock bot commented May 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants