Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix broken netstats ip forward polling #5575

Merged
merged 2 commits into from Jan 24, 2017
Merged

fix: Fix broken netstats ip forward polling #5575

merged 2 commits into from Jan 24, 2017

Conversation

Rosiak
Copy link
Member

@Rosiak Rosiak commented Jan 24, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

@mention-bot
Copy link

Thank you for submitting a PR @Rosiak! We have found the following @murrant, @zarya and @laf based on the history of these files to review this PR.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://5575.ci.librenms.org or https://5575.ci.librenms.org

murrant
murrant reviewed Jan 24, 2017
View reviewed changes
includes/polling/netstats/netstats-ip_forward.inc.php
} else {
$value = 'U';
}
$rrd_def = array();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a single RRD def, you can just use

 $rrd_def = "DS:$oid:GAUGE:600:U:5000000";

Doesn't need to be an array.

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://5575.ci.librenms.org or https://5575.ci.librenms.org

@laf laf merged commit f4b21ae into librenms:master Jan 24, 2017
@Rosiak Rosiak deleted the ip-forward-fix branch February 5, 2017 14:42
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@murrant murrant murrant left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Rosiak @mention-bot @LibreNMS-CI @scrutinizer-notifier @murrant @laf