Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SMART app support #6181

Merged
merged 7 commits into from Mar 22, 2017
Merged

add SMART app support #6181

merged 7 commits into from Mar 22, 2017

Conversation

VVelox
Copy link
Contributor

@VVelox VVelox commented Mar 13, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Replaces #6128 as that one ate it's self in a rebase.

Depends on librenms/librenms-agent#101 .

@mention-bot
Copy link

Thank you for submitting a PR @VVelox! We have found the following @murrant, @crcro and @karlshea based on the history of these files to review this PR.

@VVelox VVelox mentioned this pull request Mar 13, 2017
2 tasks
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6181.ci.librenms.org or https://6181.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues, 1 updated code elements

@laf laf mentioned this pull request Mar 15, 2017
@laf
Copy link
Member

laf commented Mar 15, 2017

I've put a mention up on community and an old issue here to test this.

@sorano
Copy link
Contributor

sorano commented Mar 20, 2017

I tested this last week and after some fixes in the script from VVelox it worked.

@laf laf merged commit 0a4b265 into librenms:master Mar 22, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
@VVelox VVelox deleted the SMART-new branch March 11, 2019 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants