newdevice: Added support for Teradici PCoIP card #6347
Conversation
|
Thank you for submitting a PR @enzozafra! We have found the following @laf, @murrant and @Rosiak based on the history of these files to review this PR. |
|
Auto-Deploy finished, Test PR at http://6347.ci.librenms.org or https://6347.ci.librenms.org |
laf
changed the title
| - teradici | ||
| over: | ||
| - { graph: device_bits, text: 'Device Bits' } | ||
| #- { graph: device_pcoip-net-latency, text: 'Net Latency' } |
There was a problem hiding this comment.
can you remove the two commented out lines please.
| //SNMPv2-SMI::enterprises.25071.1.2.6.1.1.8.1 = STRING: "DXM13-9 PV2.0.D" | ||
| //SNMPv2-SMI::enterprises.25071.1.2.6.1.1.9.1 = STRING: "4.7.5" | ||
|
|
||
| $hardware = trim(snmp_get($device, '1.3.6.1.4.1.25071.1.2.6.1.1.5.1', '-OQv', '', ''), '" '); |
There was a problem hiding this comment.
You don't need the , '', '' in the snmp_get call, those are optional.
|
Auto-Deploy finished, Test PR at http://6347.ci.librenms.org or https://6347.ci.librenms.org |
| @@ -0,0 +1,11 @@ | |||
| os: teradici-pcoip | |||
| text: 'Teradici PCoIP' | |||
| type: workstation | |||
There was a problem hiding this comment.
Sorry didn't spot this earlier.
If you are adding a new type then this needs to go into includes/definitions.inc.php (see network, firewall, appliance as examples).
There was a problem hiding this comment.
I see lines that point to an icon for device types, i.e. $config['device_types'][$i]['icon'] = 'server.png';
Where are these stored? I could not find them
There was a problem hiding this comment.
For now that line isn't used but it's best to keep it until we either add support or remove those config lines.
|
Auto-Deploy finished, Test PR at http://6347.ci.librenms.org or https://6347.ci.librenms.org |
|
The inspection completed: 1 updated code elements |
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926