Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Device Support - ICT DC Distribution Panel #6379

Merged
merged 5 commits into from Apr 12, 2017
Merged

New Device Support - ICT DC Distribution Panel #6379

merged 5 commits into from Apr 12, 2017

Conversation

enzozafra
Copy link
Contributor

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you signed the Contributors agreement - please do NOT submit a pull request unless you have (signing the agreement in the same pull request is fine). Your commit message for signing the agreement must appear as per the docs.
  • Have you followed our code guidelines?

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

  • Supports current, voltage and fuse state sensors

@mention-bot
Copy link

Thank you for submitting a PR @enzozafra! We have found the following @murrant, @laf and @Rosiak based on the history of these files to review this PR.

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6379.ci.librenms.org or https://6379.ci.librenms.org

@enzozafra enzozafra closed this Apr 7, 2017
@enzozafra enzozafra reopened this Apr 7, 2017
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6379.ci.librenms.org or https://6379.ci.librenms.org

1 similar comment
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6379.ci.librenms.org or https://6379.ci.librenms.org

@enzozafra enzozafra closed this Apr 7, 2017
@enzozafra enzozafra reopened this Apr 7, 2017
@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6379.ci.librenms.org or https://6379.ci.librenms.org

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6379.ci.librenms.org or https://6379.ci.librenms.org

murrant
murrant approved these changes Apr 8, 2017
View reviewed changes
Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I assume you tested against the actual hardware?

@enzozafra
Copy link
Contributor Author

Yep, checked and its good!

@LibreNMS-CI
Copy link

Auto-Deploy finished, Test PR at http://6379.ci.librenms.org or https://6379.ci.librenms.org

@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues, 2 updated code elements

@murrant murrant merged commit 457f2e9 into librenms:master Apr 12, 2017
@murrant
Copy link
Member

murrant commented Apr 12, 2017

👍

@enzozafra enzozafra mentioned this pull request Apr 13, 2017
Closed
5 tasks
@enzozafra enzozafra deleted the issue-6374 branch April 13, 2017 15:40
@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@murrant murrant murrant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@enzozafra @mention-bot @LibreNMS-CI @scrutinizer-notifier @murrant