Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newdevice: Added further sensor support for Geist Watchdog #7143

Merged
merged 2 commits into from Aug 19, 2017

Conversation

laf
Copy link
Member

@laf laf commented Aug 11, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Fixes: #7082

Adds some more functions:

conv_fahrenheit() This converts fahrenheit to celsius. It re-uses another function to simplify things

return_number() This parses the value passed and returns just a numerical value.

Fixes issues with existing sensor discovery in some files.

Added new ones via yaml. The device provided to test against barely had any sensors available so this is all from the mib....

image

@laf laf added the Device 🖥️ New or added device support label Aug 11, 2017
@mention-bot
Copy link

Thank you for submitting a PR @laf! We have found the following @murrant, @paulgear and @BarbarossaTM based on the history of these files to review this PR.

@scrutinizer-notifier
Copy link

The inspection completed: 1 new issues, 2 updated code elements

@laf laf merged commit 25d79ce into librenms:master Aug 19, 2017
@laf laf deleted the device/issue-7082 branch August 19, 2017 19:22
@lock
Copy link

lock bot commented May 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants