Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui: Expose pollers link to show total poll time for all devices per poller #7699

Merged
merged 2 commits into from Nov 13, 2017

Conversation

laf
Copy link
Member

@laf laf commented Nov 9, 2017

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf laf added the WebUI label Nov 9, 2017
@murrant
Copy link
Member

murrant commented Nov 9, 2017

@laf The groups tab is exposed once you go into the pollers section. That gave me a thought.

Instead of requiring distributed_poller be set on the main node, perhaps we just count the number of poller groups before exposing the poller group setting in the add and edit device dialogs?

@laf
Copy link
Member Author

laf commented Nov 12, 2017

@laf The groups tab is exposed once you go into the pollers section. That gave me a thought.

Sorry I don't know what you mean here.

Instead of requiring distributed_poller be set on the main node, perhaps we just count the number of poller groups before exposing the poller group setting in the add and edit device dialogs?

Up to you but an additional sql query to show the link, worth it?

@murrant
Copy link
Member

murrant commented Nov 13, 2017

Creating poller groups is only relevant for people using distributed polling.

The sql query would be very quick, counting the rows on a table with probably single digit entries.

So options:

  1. Hide poller groups tab with check on the distributed polling option
  2. Change checks from option to db check. Add extra warning about creating poller groups.

@murrant
Copy link
Member

murrant commented Nov 13, 2017

After some looking at the poller-wrapper problem, I vote for 1

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@murrant murrant merged commit 4e59dd4 into librenms:master Nov 13, 2017
@laf laf deleted the webui/add-pollers-link branch November 13, 2017 19:48
@lock
Copy link

lock bot commented May 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed.

@lock lock bot locked as resolved and limited conversation to collaborators May 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants