Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail2ban: properly set the component information when polling #10017

Merged
merged 1 commit into from Mar 24, 2019

Conversation

Projects
None yet
4 participants
@VVelox
Copy link
Contributor

commented Mar 24, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

When converted to JSON, the variable got renamed. Everything was updated except for the check to see if any jail information was returned or not. It now properly checks if the correct variable is empty or not.

Currently it just displays the totals graph with out display anything else. This fixes it so it displays all the graphs for jails on a device.

@PipoCanaja
Copy link
Contributor

left a comment

LGTM

@murrant murrant merged commit bc2a0e6 into librenms:master Mar 24, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the Bug 🐞 label Mar 31, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.