Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSPF display improvements #10206

Merged
merged 1 commit into from May 11, 2019
Merged

OSPF display improvements #10206

merged 1 commit into from May 11, 2019

Conversation

dsgagi
Copy link
Contributor

@dsgagi dsgagi commented May 10, 2019

  • Fixed ospf port listing, as current query only returned ospf ports for last AreaID in area foreach loop.
  • Added Area ID column to Ports table.
  • Removed whitespaces.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

- Fixed ospf port listing, as current query only returned ospf ports for last AreaID in area foreach loop.
- Added Area ID column to Ports table.
- Removed whitespaces.
Copy link
Contributor

@PipoCanaja PipoCanaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test OK, LGTM

@PipoCanaja PipoCanaja merged commit 4313cbf into librenms:master May 11, 2019
@PipoCanaja PipoCanaja changed the title OSPF improvements - 2nd attempt OSPF display improvements May 11, 2019
@PipoCanaja
Copy link
Contributor

Thanx @dsgagi
Looks better now !

@dsgagi dsgagi deleted the dsgagi-patch-for-ospf-instances branch May 13, 2019 08:00
spencerbutler pushed a commit to spencerbutler/librenms that referenced this pull request May 21, 2019
- Fixed ospf port listing, as current query only returned ospf ports for last AreaID in area foreach loop.
- Added Area ID column to Ports table.
- Removed whitespaces.
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants