Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ipoman power consumption support #10244

Merged
merged 2 commits into from
May 31, 2019

Conversation

Marlinc
Copy link
Contributor

@Marlinc Marlinc commented May 21, 2019

This commit adds support for reading power consumption from Ipoman PDU's.

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link

CLAassistant commented May 21, 2019

CLA assistant check
All committers have signed the CLA.

@PipoCanaja PipoCanaja added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels May 21, 2019
@label-actions
Copy link

label-actions bot commented May 21, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@PipoCanaja
Copy link
Contributor

Hello @Marlinc
Thank you for your contribution ! Will have a look at it more in detail (I am not familiar with this device). But in the meantime, could you have a look at the test documentation above, and contribute it as well ? This will ensure that regression test will successfully run on this device from now on.
Thanx,

@Marlinc
Copy link
Contributor Author

Marlinc commented May 25, 2019

Hey @PipoCanaja, I have added some SNMP test data, is that what you meant?

@PipoCanaja
Copy link
Contributor

Hey @PipoCanaja, I have added some SNMP test data, is that what you meant?

Hi @Marlinc,

  • That's the 1st step of it, yes.
  • 2nd step is to run ./scripts/save-test-data.php -o ipoman
    This will generate a json file that should be added as well to the PR.

Bye

@murrant murrant merged commit 93f3528 into librenms:master May 31, 2019
@murrant murrant removed the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label May 31, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
@Marlinc Marlinc deleted the ipoman-power-consumption branch April 10, 2020 09:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants