Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for IOS Vlans/Vtp #10519

Merged
merged 3 commits into from Aug 13, 2019
Merged

Tests for IOS Vlans/Vtp #10519

merged 3 commits into from Aug 13, 2019

Conversation

PipoCanaja
Copy link
Contributor

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@PipoCanaja PipoCanaja added the Ignore changelog 🔇 If selected, will not be included in changelog label Aug 12, 2019
@PipoCanaja PipoCanaja self-assigned this Aug 12, 2019
@PipoCanaja
Copy link
Contributor Author

@murrant I think I understood why the JSON was not added ... the vlans code in ios uses a @ built community to access STP data for each VLAN ... That cannot make it in snmpsim, all of those request timeout, and that's exactly why it breaks now in Travis.
May be with a lighter snmprec (less vlans) it could be possible. I'll try to get down to 2 vlans only for the testfile.

@murrant
Copy link
Member

murrant commented Aug 13, 2019

Running it locally, it works but it is soooooooo sloooooow... it doesn't complete within the time window.

@murrant murrant merged commit 4631705 into librenms:master Aug 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 12, 2019
@PipoCanaja PipoCanaja deleted the tests_vtp branch March 17, 2020 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ignore changelog 🔇 If selected, will not be included in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants