Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some graphs having the wrong timeframe #10554

Merged
merged 1 commit into from Aug 22, 2019
Merged

Conversation

murrant
Copy link
Member

@murrant murrant commented Aug 22, 2019

Unverified

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added Bug 🕷️ Needs Testing Waiting for others to verify that the code functions properly. Graphs labels Aug 22, 2019
@murrant
Copy link
Member Author

murrant commented Aug 22, 2019

Confirmed by smiles on Discord.

@murrant murrant removed the Needs Testing Waiting for others to verify that the code functions properly. label Aug 22, 2019
@murrant
Copy link
Member Author

murrant commented Aug 22, 2019

Another possible fix might be to delete these lines altogether. Not sure of any side effects of that though.

Copy link
Member

@laf laf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laf laf merged commit f1a7379 into librenms:master Aug 22, 2019
@laf laf deleted the fix-graphs branch August 22, 2019 21:23
@murrant
Copy link
Member Author

murrant commented Sep 3, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-55-release-changelog-august-2019/9428/1

@lock lock bot locked as resolved and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants