New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow all models of Asentria SiteBoss #10746
Allow all models of Asentria SiteBoss #10746
Conversation
.1.3.6.1.4.1.3052 belongs to all of Asentria Corp |
Hi @willhseitz |
Please add test data so we can ensure your change is not broken in the future. Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units |
…pand-siteboss-definitions
Hi @PipoCanaja, I have set up a dev environment, but I am having difficulty with snmpsim. When I try to run
I still receive that error after running
I am running both as librenms user. I did not find much information regarding these types of snmpsim errors on the community forum :( |
You need to make sure snmpsim.py is in your PATH, or modify the script to point to the file directly. |
Thanks, I updated librenms user PATH and was able to export snmpsim data. EDIT: here is the siteboss.snmprec.txt file if needed |
Hi @willhseitz Thanx for the test data. I added the snmprec file and the JSON matching file (you can compute it yourself using ./script/save-test-data.php -o siteboss -v 2). '-v 2' means : create a new version 2 instead of messing the current version. For next time, you can directly add the files to the PR. We'll see how the tests are going, review and merge your PR Thanx for your contribution ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-58-release-changelog-november-2019/10224/1 |
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 10746
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.