Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all models of Asentria SiteBoss #10746

Merged
merged 5 commits into from Nov 3, 2019

Conversation

haydenseitz
Copy link
Contributor

@haydenseitz haydenseitz commented Oct 25, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 10746
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@haydenseitz
Copy link
Contributor Author

.1.3.6.1.4.1.3052 belongs to all of Asentria Corp

http://oid-info.com/get/1.3.6.1.4.1.3052

@PipoCanaja PipoCanaja added the Device 🖥️ New or added device support label Oct 25, 2019
@PipoCanaja
Copy link
Contributor

Hi @willhseitz
Thanx for your PR. Could you add some test data as well for such a device ?
Bye

@PipoCanaja PipoCanaja added the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Oct 25, 2019
@label-actions
Copy link

label-actions bot commented Oct 25, 2019

Please add test data so we can ensure your change is not broken in the future.

Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@haydenseitz
Copy link
Contributor Author

Hi @PipoCanaja,

I have set up a dev environment, but I am having difficulty with snmpsim. When I try to run ./scripts/save-test-data.php -o siteboss, I receive this error:

Starting snmpsim listening on 127.1.6.1:1161...
sh: 1: snmpsimd.py: not found

Could not find snmpsim, you can install it with 'pip install snmpsim'.  If it is already installed, make sure snmpsimd or snmpsimd.py is in PATH

I still receive that error after running pip install snmpsim and pip3 install snmpsim. I also tried installing snmpsim via U18 APT (apt install snmpsim), and this is the error I get then:

Starting snmpsim listening on 127.1.6.1:1161...
Traceback (most recent call last):
  File "/usr/bin/snmpsimd", line 549, in <module>
    '|'.join([ x for x in pyasn1_debug.flagMap.keys() ]),
AttributeError: 'module' object has no attribute 'flagMap'

Failed to start Snmpsim. Scroll up for error.

I am running both as librenms user. I did not find much information regarding these types of snmpsim errors on the community forum :(
If you can point me toward any resources to help with this, I would appreciate it!

@Jellyfrog
Copy link
Member

Could not find snmpsim, you can install it with 'pip install snmpsim'.  If it is already installed, make sure snmpsimd or snmpsimd.py is in PATH

make sure snmpsimd or snmpsimd.py is in PATH

You need to make sure snmpsim.py is in your PATH, or modify the script to point to the file directly.

@haydenseitz
Copy link
Contributor Author

haydenseitz commented Oct 28, 2019

Thanks, I updated librenms user PATH and was able to export snmpsim data.
I followed these instructions to get the attached siteboss.json.txt file.

EDIT: here is the siteboss.snmprec.txt file if needed

@PipoCanaja PipoCanaja removed the Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ label Nov 3, 2019
@PipoCanaja
Copy link
Contributor

PipoCanaja commented Nov 3, 2019

Hi @willhseitz

Thanx for the test data. I added the snmprec file and the JSON matching file (you can compute it yourself using ./script/save-test-data.php -o siteboss -v 2). '-v 2' means : create a new version 2 instead of messing the current version.

For next time, you can directly add the files to the PR.

We'll see how the tests are going, review and merge your PR

Thanx for your contribution !

@PipoCanaja PipoCanaja changed the title allow all models of Asentria SiteBoss Allow all models of Asentria SiteBoss Nov 3, 2019
@PipoCanaja PipoCanaja self-assigned this Nov 3, 2019
Copy link
Contributor

@PipoCanaja PipoCanaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PipoCanaja PipoCanaja merged commit 464fd27 into librenms:master Nov 3, 2019
@haydenseitz haydenseitz deleted the expand-siteboss-definitions branch November 4, 2019 19:20
@murrant
Copy link
Member

murrant commented Nov 25, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-58-release-changelog-november-2019/10224/1

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants