Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZyXEL IES-5005 and IES-5106 DSLAMs #10804

Merged
merged 3 commits into from Nov 16, 2019

Conversation

vitalisator
Copy link
Contributor

@vitalisator vitalisator commented Nov 11, 2019

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Jellyfrog Jellyfrog added the Device 🖥️ New or added device support label Nov 11, 2019
@Jellyfrog
Copy link
Member

Please remove "WIP" from the title when your pull request is ready

@Jellyfrog Jellyfrog added the User-Pending Currently waiting for user response label Nov 11, 2019
@vitalisator
Copy link
Contributor Author

Please remove "WIP" from the title when your pull request is ready

I still waiting for merge of #10789 , then we need a rebase here.

@vitalisator vitalisator changed the title WIP Add support for ZyXEL IES-5005 and IES-5106 DSLAMs Add support for ZyXEL IES-5005 and IES-5106 DSLAMs Nov 12, 2019
@PipoCanaja PipoCanaja removed the User-Pending Currently waiting for user response label Nov 13, 2019
includes/polling/os/ies5000.inc.php Outdated Show resolved Hide resolved
@laf laf added the User-Pending Currently waiting for user response label Nov 13, 2019
@PipoCanaja PipoCanaja removed the User-Pending Currently waiting for user response label Nov 15, 2019
Copy link
Contributor

@PipoCanaja PipoCanaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PipoCanaja PipoCanaja merged commit 7c1e6cb into librenms:master Nov 16, 2019
@murrant
Copy link
Member

murrant commented Nov 25, 2019

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-58-release-changelog-november-2019/10224/1

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants