Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OPNsense definition due to incorrect OID on second detection method #11265

Merged
merged 2 commits into from Mar 9, 2020
Merged

Update OPNsense definition due to incorrect OID on second detection method #11265

merged 2 commits into from Mar 9, 2020

Conversation

FingerlessGlov3s
Copy link
Contributor

sysObjectID is incorrect for OPNsense should be .1.3.6.1.4.1.8072.3.2.8.
This has been tested in my environment with 2 OPNsense Firewalls.

Redoing PR due to deleting Repo before I should have done.
#11251

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Update OPNsense snmprec, with real data.

Data from OPNsense 20.1.2 (Latest release at time of commit)
sysObjectID is incorrect for OPNsense should be .1.3.6.1.4.1.8072.3.2.8.  for this snmpget detection to work.
This has been tested in my environment with 2 OPNsense Firewalls.
Copy link
Contributor

@PipoCanaja PipoCanaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PipoCanaja PipoCanaja merged commit dcc6b9a into librenms:master Mar 9, 2020
@murrant murrant added the Device 🖥️ New or added device support label Apr 1, 2020
@murrant
Copy link
Member

murrant commented Apr 1, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-62-release-changelog-march-2020/11423/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants