Database: add primary key to device_graphs

[rkojedzinszky]

Percona Xtradb refused to INSERT IGNORE into a table
without a primary key.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[Jellyfrog]

This can't be right?

[rkojedzinszky]

Actually, that table might contain duplicates, as no constraint prevented that. Thus, clear the table, then add the primary key. Also, poller modules will fill the table upon next run. Am I right?

[murrant]

@rkojedzinszky you can run through and delete duplicates first.

[rkojedzinszky]

Unfortunately, on a table without a primary key, you cannot delete just duplicates. You cannot identify them :)

[murrant]

Add a new column with a primary key first then.

[rkojedzinszky]

Unfortunately, I am not a php developer, and perhaps, a bigger refactor would be needed here, which I cannot handle. The original problem involves a table without primary key and inserting into it with insert ignore. This breaks librenms on percona xtradb. Perhaps, the real solution is somewhere else.

[murrant]

IMO, delete duplicates, add primary key id, add unique index on device_id and graph.