Syslog -> Added colour priority to the label column #11607
Conversation
| * @param int $syslog_priority | ||
| * @return string $syslog_priority_icon | ||
| */ | ||
| private function priorityLabel($syslog_priority) |
There was a problem hiding this comment.
This should be a common function, if you search for label-danger in the code you see how many places does the same thing over and over :/
There was a problem hiding this comment.
I know, I took it from the EventlogController.
But what is best, one func with lots of conditionals or different functions even doing "the same"?
For example, eventlog handles with numeric "severity" while syslog does by string "priority".
There was a problem hiding this comment.
@Jellyfrog do you think I have to do a different approach with what I've said about different conditions?
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-65-release-changelog-june-2020/12687/1 |
1 similar comment
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-65-release-changelog-june-2020/12687/1 |
Now the label column have the corresponding colour based on priority.
Feel free to comment if I should change any colour<->priority.
Before:
After:
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.