WebUI: Fixed URL of detailed graphs for jitter SLA probe #11984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blank lines at the start and end of control structure
|
Looks fine to me, I didn't test it though. Ideally, the code gets moved to the SlasController and a new blade file. |
murrant
approved these changes
Sep 18, 2020
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-68-release-changelog-september-2020/13525/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrog/obsolete URL for jitter probes in SLAs overview page that should point to a page with multiple graphs for a single probe. URL was generated with
'tab' => "sla", and although there is aincludes/html/pages/device/sla.inc.phppage, there is noslatab defined inDeviceControllerand there's noSlaControllerclass.Instead of making a new Controller class i moved the code from
includes/html/pages/device/sla.inc.phptoincludes/html/pages/device/slas.inc.phpand changed the link to point toslastab. That way we also avoid the situation we have withportsandporttabs, whereportis a hidden tab and there is no appropriate tab highlighted in UI when looking at single port data.Other changes include setting the lower limit to 0 for SLA RTT graph and changing the line color and unit of lost packets on jitter graph.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.