Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UBNT switch discovery issue-12133 #12167

Merged
merged 1 commit into from Sep 29, 2020
Merged

UBNT switch discovery issue-12133 #12167

merged 1 commit into from Sep 29, 2020

Conversation

kanokc
Copy link
Contributor

@kanokc kanokc commented Sep 29, 2020

To be able to detect Ubiquiti switch that report model name starting with US eg. US-16-150W
Some Ubiquiti switches answer snmp query just the model number such as:

librenms@librenms:~$ snmpbulkwalk -v2c -c kenny 192.168.1.2|more
iso.3.6.1.2.1.1.1.0 = STRING: "US-16-150W, 5.37.2.12269, Linux 3.6.5"
iso.3.6.1.2.1.1.2.0 = OID: iso.3.6.1.4.1.4413

Which is not defined in edgeswitch.yaml While Inteno GW which has the same OID and not specified sysDescr_regex. That is the reason why Ubiquiti switch was detected as Inteno GW.

librenms@librenms:~/includes/definitions$ cat inteno.yaml
os: inteno
text: 'Inteno GW'
type: network
over:
    - { graph: device_bits, text: Traffic }
mib_dir: inteno
icon: inteno
discovery:
    -
        sysObjectID:
            - .1.3.6.1.4.1.4413
        sysDescr_regex_except:
            - '/VxWorks/'
            - '/quanta/i'
            - '/FASTPATH (Switching|Routing)/'

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

To be able to detect Ubiquiti swtich that report model name starting with US  eg. US-16-150W
@CLAassistant
Copy link

CLAassistant commented Sep 29, 2020

CLA assistant check
All committers have signed the CLA.

@kanokc kanokc changed the title issue-12133 UBNT switch discovery issue-12133 Sep 29, 2020
@Jellyfrog Jellyfrog added the Device 🖥️ New or added device support label Sep 29, 2020
@Jellyfrog Jellyfrog merged commit 2f0c3f6 into librenms:master Sep 29, 2020
@murrant
Copy link
Member

murrant commented Sep 29, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/wrong-ubnt-switch-discovery/13434/4

@murrant
Copy link
Member

murrant commented Sep 30, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-68-release-changelog-september-2020/13525/1

@pozar
Copy link

pozar commented Jan 13, 2024

The mis-identity is also showing up on UI's UISP Fiber OLT XGS boxes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants