Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo cause empty data for NFS Server #12223

Merged
merged 1 commit into from Oct 16, 2020

Conversation

clarkchentw
Copy link
Contributor

@clarkchentw clarkchentw commented Oct 16, 2020

Typo causing NFS tab data aren't polling properly

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Typo causing NFS tab data aren't polling properly
@SourceDoctor SourceDoctor self-requested a review October 16, 2020 08:52
Copy link
Member

@SourceDoctor SourceDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx LGTM

@SourceDoctor SourceDoctor merged commit 2f61f50 into librenms:master Oct 16, 2020
@murrant
Copy link
Member

murrant commented Nov 2, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-69-release-changelog-october-2020/13837/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants