VRP NAC polling optimisation #12279
Merged
VRP NAC polling optimisation #12279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jellyfrog
reviewed
Nov 1, 2020
| 'hwAccessVLANID', | ||
| ]; | ||
| foreach ($hwAccessOids as $hwAccessOid) { | ||
| $portAuthSessionEntry = snmpwalk_cache_oid($this->getDeviceArray(), $hwAccessOid, $portAuthSessionEntry, 'HUAWEI-AAA-MIB'); |
There was a problem hiding this comment.
I might be missing something but isn't this just overwriting $portAuthSessionEntry over Again?
There was a problem hiding this comment.
snmpwalk_cache_oid is populating the input array (3rd parameter) and returning the result. So $portAuthSessionEntry after the loop filled with all the values.
There was a problem hiding this comment.
Oh. My bad. Can't we use one of the "multi" functions here instead tho?
There was a problem hiding this comment.
The multi functions are only for snmpget calls. snmpwalk does not support multi OIDs.
murrant
approved these changes
Nov 8, 2020
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/v1-69-release-changelog-november-2020/14124/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of polling a very large table for only a part of the OIDs, we only walk the OIDs we need.
11 small snmpwalk_cache_oids calls instead of 2 big ones.
6 seconds instead of 20 seconds on my stacks.
Please give a short description what your pull request is for
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.