Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only add new outage entry if Device status changed #12309

Merged
merged 2 commits into from Nov 9, 2020

Conversation

SourceDoctor
Copy link
Member

@SourceDoctor SourceDoctor commented Nov 8, 2020

change of status reason on offline devices causes new outage entry without "recovering" entry before.
Outage is a outage, a change of the reason doesn't care, so a new outage only has to be added if device status has changed

happens e.G. if a problematic device is flapping between
"Device status changed to Down from snmp check." and "Device status changed to Down from icmp check."

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant merged commit 76ab814 into librenms:master Nov 9, 2020
@murrant
Copy link
Member

murrant commented Dec 2, 2020

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-69-release-changelog-november-2020/14124/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants