Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to check if os parameter matches filename #12442

Merged
merged 1 commit into from Jan 26, 2021

Conversation

Jellyfrog
Copy link
Member

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Jellyfrog Jellyfrog added the Tests 🧪 Test for Code label Jan 18, 2021
@Jellyfrog
Copy link
Member Author

ping @murrant

Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that there were existing ones that didn't match.
I'm unsure if that breaks anything, but it should be fine.

@murrant murrant merged commit 4ba0958 into librenms:master Jan 26, 2021
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-1-0-changelog/14698/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests 🧪 Test for Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants