Correct snmp function usage #12714
Correct snmp function usage #12714
Conversation
| $device->version = snmp_get($device, $firmware_oid, '-Oqv') ?: null; | ||
| $device->hardware = trim($device->sysDescr . ' ' . snmp_get($device, $hardware_oid, '-Oqv')); | ||
| $device->version = snmp_get($this->getDeviceArray(), $firmware_oid, '-Oqv') ?: null; | ||
| $device->hardware = trim($device->sysDescr . ' ' . snmp_get($this->getDeviceArray(), $hardware_oid, '-Oqv')); |
There was a problem hiding this comment.
I suspect this doesn't break/fixes the tests because we don't have any real test data for it :)
LibreNMS/OS/ArubaInstant.php
Outdated
| @@ -111,7 +111,7 @@ public function discoverWirelessClients() | |||
| // Clients Per SSID | |||
| foreach ($ssid_data as $index => $entry) { | |||
| $combined_oid = sprintf('%s::%s.%s', $ai_mib, 'aiSSIDClientNum', $index); | |||
| $oid = snmp_translate($combined_oid, 'ALL', 'arubaos', '-On', null); | |||
| $oid = snmp_translate($combined_oid, 'ALL', 'arubaos', '-On', $this->getDeviceArray()); | |||
There was a problem hiding this comment.
device is not required for snmp_translate().
Should either omit the 'arubaos' mib directory or the device argument.
There was a problem hiding this comment.
>>> snmp_translate('foobar'', 'ALL', 'arubaos', '-On', null);
<warning>PHP Notice: Trying to access array offset on value of type null in librenms/includes/snmp.inc.php on line 50</warning>
<warning>PHP Notice: Trying to access array offset on value of type null in librenms/includes/snmp.inc.php on line 51</warning>
<warning>PHP Notice: Trying to access array offset on value of type null in librenms/includes/snmp.inc.php on line 68</warning>librenms/includes/snmp.inc.php
Lines 46 to 73 in 40517f6
There was a problem hiding this comment.
The default for the device argument is [], just delete the stupid null.
There was a problem hiding this comment.
I fixed it better instead
device array instead of object
Jellyfrog
force-pushed
the
bug/snmp-device
branch
from
51ca861
to
36a0f19
Compare
| * @return string | ||
| */ | ||
| function snmp_translate($oid, $mib = 'ALL', $mibdir = null, $options = null, $device = []) | ||
| function snmp_translate($oid, $mib = 'ALL', $mibdir = null, $options = null, $device = null) |
There was a problem hiding this comment.
No that's what we wanted to get away from.
No point in sending a empty array when we're only interested in it if it's a "device array".
It's sent to mibdir which does a is_array check
There was a problem hiding this comment.
Best would ofc be to send the device object instead... One day. One day.
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Please give a short description what your pull request is for
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.