Fix allow_unauth_graphs #12829
Merged
Fix allow_unauth_graphs #12829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/allow-unauth-graphs-not-working-anymore/15700/4 |
murrant
approved these changes
May 4, 2021
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the functionality of the setting "allow_unauth_graphs" which does not work anymore since the "Rrd graph optimizations" patch. The variable $auth is already set in html/graph.php when the setting "allow_unauth_graphs" is set. But this variable gets overwritten in includes/html/graphs/graph.inc.php. With this patch the variable $auth is initialized in html/graph.php before checking if the user is allowed to view the graph.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.