Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Sub-directory Support" in small steps #12910

Merged
merged 8 commits into from Jun 15, 2021
Merged

Conversation

mpikzink
Copy link
Contributor

This fixes small parts from #12205 part 3
fixes #12205

Even someone knows a better way, for example to fix js with the url() function. In my case it works.

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

This fixes small parts from librenms#12205 part 3
fixes librenms#12205

Even someone knows a better way, for example to fix js with the url() function. In my case it works.
includes/html/pages/oxidized.inc.php Outdated Show resolved Hide resolved
@PipoCanaja
Copy link
Contributor

Hi @mpikzink
I am currently on holidays and should be able to have a look at this in about 1 week. Looks good "in theory", but I have no way to test it currently.
Thx

@mpikzink
Copy link
Contributor Author

Hi @PipoCanaja
No rush! Whenever you find the time. It's not that urgent. Enjoy your holidays!!!

@mpikzink
Copy link
Contributor Author

@murrant
Can you please check again if I understood you correctly regarding the URL?

@murrant
Copy link
Member

murrant commented Jun 15, 2021

Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tested.

@murrant murrant merged commit 0489382 into librenms:master Jun 15, 2021
@murrant murrant added the WebUI label Jun 18, 2021
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-6-0-changelog/16173/1

trympet pushed a commit to trympet/librenms that referenced this pull request Oct 28, 2021
* Fix "Sub-directory Support" in small steps

This fixes small parts from librenms#12205 part 3
fixes librenms#12205

Even someone knows a better way, for example to fix js with the url() function. In my case it works.

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php

* Update oxidized.inc.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sub-directory Support" does not accept top-level (root) URL
4 participants