Help users that did not upgrade MySQL try two

[murrant]

Instead of dropping the table and re-creating. Just try adding the index. This way it won't fail if they somehow did the port_group_port migration first. And still should fail if the index cannot be created.

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[Jellyfrog]

Problem is this will just keep happening with the next migration, we should block even running the migrations command instead

[murrant]

No, it will keep hanging at this migration until they upgrade MySQL. This will try to add the index and it will fail. (I have not tested that)

[murrant]

We really can't block migrations as it will cause the ui to be unreachable if they are out of sync. We could have blocked updates entirely, but that needed to be done before this migration was committed. And so we are here.

[librenms-bot]

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-7-0-changelog/16425/1