Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added H3C / Comware MIB files #13102

Merged
merged 2 commits into from Aug 6, 2021
Merged

Added H3C / Comware MIB files #13102

merged 2 commits into from Aug 6, 2021

Conversation

Laplacence
Copy link
Contributor

@Laplacence Laplacence commented Aug 4, 2021

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2021

CLA assistant check
All committers have signed the CLA.

@PipoCanaja
Copy link
Contributor

PipoCanaja commented Aug 4, 2021

Hello @Laplacence
Thanx for your PR. Are you planning to add support in LibreNMS for these 260 mibs or so ?
The best practice is to add them as soon as some code in LibreNMS is using them, or could easily use them. For instance, all mibs related to an existing module (even if this module is not (yet) implemented for HH3C) would be nice to add.
Even if the files are small in average, that's a lot of files :) And you can probably make it a little bit lighter :)

Thanx

@PipoCanaja PipoCanaja changed the title add h3c device mib files Added H3C / Comware MIB files Aug 4, 2021
@PipoCanaja PipoCanaja added the MIBs label Aug 4, 2021
@Laplacence
Copy link
Contributor Author

@PipoCanaja Thx for reply! I have no plans to develop for this part for the time being.
I got this part of the file from the h3c, and thought it might be useful for subsequent development, so I uploaded it first.

@PipoCanaja
Copy link
Contributor

OK. Could you please proceed with the CLA (Contributor Licence) ?

@Laplacence
Copy link
Contributor Author

OK, done it.:-)

Copy link
Contributor

@PipoCanaja PipoCanaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PipoCanaja PipoCanaja merged commit cecfe91 into librenms:master Aug 6, 2021
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-8-0-changelog/16685/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants