Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center new service window #13115

Merged
merged 2 commits into from Aug 21, 2021
Merged

Center new service window #13115

merged 2 commits into from Aug 21, 2021

Conversation

arjitc
Copy link
Contributor

@arjitc arjitc commented Aug 7, 2021

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

What changed,

Small UI fix/change to fix the width of the services form,

Before:

image

After:

image

@murrant
Copy link
Member

murrant commented Aug 7, 2021

I would think adding col-sm-offset-3 would be a better fix.

@murrant murrant added the WebUI label Aug 21, 2021
@murrant murrant merged commit 1fcf58a into librenms:master Aug 21, 2021
@murrant murrant changed the title Fix layout width Center new service window Aug 21, 2021
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-8-0-changelog/16685/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants