Feat/nokia opticalpower multilane #13165
Conversation
|
Kate Robinson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
|
| @@ -11,3 +11,6 @@ | |||
| */ | |||
|
|
|||
| $pre_cache['timos_oids'] = snmpwalk_cache_multi_oid($device, 'tmnxDigitalDiagMonitorEntry', [], 'TIMETRA-PORT-MIB', 'timos'); | |||
| $pre_cache['timos_lane_oids'] = snmpwalk_cache_multi_oid($device, 'tmnxPortEntry', [], 'TIMETRA-PORT-MIB', 'timos'); | |||
There was a problem hiding this comment.
Please put these in the discovery file and not in pre-cache. They aren't shared across modules at all. Using pre-cache for data like this makes things slower.
| * tmnxDDMLaneRX(TX)OpticalPower is in tmnxDDMLaneEntry which is in table tmnxDDMLaneTable | ||
| * snmpbulkwalk -m +ALL -M +/opt/librenms/mibs/nokia -v [snmpversionnumber] -c [communitystring] devicename -On tmnxPortSFPNumLanes | ||
| **/ | ||
| foreach ($pre_cache['timos_lane_oids'] as $index => $entry) { |
There was a problem hiding this comment.
It looks like these could be done in yaml: https://docs.librenms.org/Developing/os/Health-Information/
murrant
added
Device 🖥️
|
Please add test data so we can ensure your change is not broken in the future. Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: https://community.librenms.org/t/add-support-for-mutli-lane-optics-for-nokia-timos/14658/3 |
| $numlanes = snmpwalk_cache_multi_oid($device, 'tmnxPortEntry', [], 'TIMETRA-PORT-MIB', 'timos'); | ||
| $lanes = snmpwalk_cache_multi_oid($device, 'tmnxDDMLaneEntry', [], 'TIMETRA-PORT-MIB', 'timos'); | ||
|
|
||
| foreach ($numlanes as $index => $entry) { |
There was a problem hiding this comment.
Why do we walk tmnxPortTable first and not just walk tmnxDDMLaneTable?
If you think we need to walk tmnxPortTable, you really only use tmnxPortSFPNumLanes, so just walk that.
|
Thanks for the updates. I have some more suggestions. Additionally, if my suggestions work, we can definitely move this to yaml. |
|
Thanks for your pull request. You haven't updated this PR in some time. Closing it for now. I could help out a bit if there was test data. Please feel free to reopen, I would love to see your changes added to LibreNMS. |
Description: Adding support for Nokia multilane optics in the dBm sensor.
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.