Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static alert rule creation failing in api #13222

Merged
merged 1 commit into from Sep 11, 2021

Conversation

murrant
Copy link
Member

@murrant murrant commented Sep 10, 2021

fixes #13211

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Copy link
Member

@SourceDoctor SourceDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jellyfrog Jellyfrog merged commit 055895e into librenms:master Sep 11, 2021
@murrant murrant deleted the api-alert-rule-fix branch September 12, 2021 15:09
@murrant murrant added the Ignore changelog 🔇 If selected, will not be included in changelog label Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Bug 🕷️ Ignore changelog 🔇 If selected, will not be included in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add_device_group API call for type='static' fails with 'HTTP Error 500: We couldn't parse your rule' error
3 participants