Remove unused snom files #13369
Merged
Remove unused snom files #13369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No snom os exists anymore. According to very old files, sysDescr should contain the string "snom". I checked on stats and no one reports an snom phone added to LibreNMS. I can't add the os detection, so just remove these. Netstats PR will remove other snom references
Jellyfrog
approved these changes
Oct 17, 2021
eskyuu
pushed a commit
to eskyuu/librenms
that referenced
this pull request
Oct 21, 2021
No snom os exists anymore. According to very old files, sysDescr should contain the string "snom". I checked on stats and no one reports an snom phone added to LibreNMS. I can't add the os detection, so just remove these. Netstats PR will remove other snom references
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No snom os exists anymore.
According to very old files, sysDescr should contain the string "snom".
I checked on stats and no one reports an snom phone added to LibreNMS.
I can't add the os detection, so just remove these.
Netstats PR will remove other snom references
Please give a short description what your pull request is for
DO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.