Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link for can't check Python dependencies validation #13520

Merged
merged 2 commits into from Nov 17, 2021

Conversation

murrant
Copy link
Member

@murrant murrant commented Nov 15, 2021

Hopefully gives the user some direction

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Hopefully gives the user some direction
ottorei
ottorei previously approved these changes Nov 17, 2021
@Jellyfrog Jellyfrog merged commit 31c9d9c into librenms:master Nov 17, 2021
@murrant murrant deleted the python-link-to-php-fpm-as-librenms branch November 17, 2021 19:07
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/21-12-0-changelog/17740/1

NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request Dec 30, 2021
* Link for can't check Python dependencies validation
Hopefully gives the user some direction

* Fix style
NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request Dec 31, 2021
* Link for can't check Python dependencies validation
Hopefully gives the user some direction

* Fix style
NightowlKr pushed a commit to NightowlKr/librenms that referenced this pull request Dec 31, 2021
* Link for can't check Python dependencies validation
Hopefully gives the user some direction

* Fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants