Fix plugin_active check when plugin is not found #13531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jellyfrog
reviewed
Nov 17, 2021
| @@ -167,7 +167,7 @@ public function pluginExists(string $pluginName): bool | |||
| */ | |||
| public function pluginEnabled(string $pluginName): bool | |||
| { | |||
| return $this->getPlugin($pluginName)->plugin_active; | |||
| return (bool) optional($this->getPlugin($pluginName))->plugin_active; | |||
There was a problem hiding this comment.
Looksie who loves optional :D
There was a problem hiding this comment.
It does a thing, just not the best thing.
Jellyfrog
approved these changes
Nov 17, 2021
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
NightowlKr
pushed a commit
to NightowlKr/librenms
that referenced
this pull request
Dec 30, 2021
* Fix plugin_active check when plugin is not found * update baseline * revert incorrect commit
NightowlKr
pushed a commit
to NightowlKr/librenms
that referenced
this pull request
Dec 31, 2021
* Fix plugin_active check when plugin is not found * update baseline * revert incorrect commit
NightowlKr
pushed a commit
to NightowlKr/librenms
that referenced
this pull request
Dec 31, 2021
* Fix plugin_active check when plugin is not found * update baseline * revert incorrect commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error when loading hook App\Plugins\ExamplePlugin\Settings of type App\Plugins\Hooks\SettingsHook for ExamplePlugin: Attempt to read property "plugin_active" on nullPlease note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.