Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NULL device alert caused by services #13663

Merged
merged 1 commit into from Jan 11, 2022

Conversation

k0079898
Copy link
Contributor

@k0079898 k0079898 commented Jan 11, 2022

Fix #13424

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2022

CLA assistant check
All committers have signed the CLA.

@murrant murrant closed this Jan 11, 2022
@murrant murrant reopened this Jan 11, 2022
@murrant murrant merged commit a2ad39a into librenms:master Jan 11, 2022
@murrant
Copy link
Member

murrant commented Jan 11, 2022

Nice work @k0079898

@k0079898 k0079898 deleted the fix-null-device-alert branch January 12, 2022 01:32
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-1-0-changelog/17974/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service alerts cause "Rule created, no errors found" history entries
4 participants