Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement system for user packages in composer #13718

Merged
merged 1 commit into from Feb 2, 2022

Conversation

Jellyfrog
Copy link
Member

Will be needed in the future

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Jellyfrog Jellyfrog force-pushed the feature/composer-plugins branch 2 times, most recently from 3dbb369 to 90b3ba7 Compare January 27, 2022 19:08
@Jellyfrog Jellyfrog marked this pull request as ready for review January 30, 2022 00:51
@Jellyfrog Jellyfrog force-pushed the feature/composer-plugins branch 2 times, most recently from 080f5e6 to 5212b65 Compare January 30, 2022 00:54
Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jellyfrog Jellyfrog merged commit fdebee8 into librenms:master Feb 2, 2022
@Jellyfrog Jellyfrog deleted the feature/composer-plugins branch February 2, 2022 16:33
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-2-0-release/18177/1

@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/22-2-0-changelog/18177/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants