-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite service checks #14071
base: master
Are you sure you want to change the base?
Rewrite service checks #14071
Conversation
dba03a4
to
399c546
Compare
8688aca
to
db6fe05
Compare
As suggested on discord, here my proposed extensions for service plugins:
I guess the second point would be more straightforward to implement. I might be able to contribute there, let me know whether that would be desirable or I should open a separate PR (probably waiting on this one then) |
@moschroe Thanks for the input. If you would like to help out with this, you can send a pull request directly to my branch. https://github.com/murrant/librenms/tree/rewrite_services Also, creating services is quite broken right now in this PR. |
Remove includes/services.inc.php
Implement parsing of check parameters for use in the webui.
Set service_ip to null to signify this.
Work around upstream mssql_health bug where KB is kb.
fix param loading
(but allow it in all other situations)
Ability to dump, but no way to feed data right now. Could mock check cli output in the future.
Display placeholder correctly
7b33c30
to
2a053c0
Compare
Needs rework due to not including arguments, only options. |
Rewrite services to improve security
Adds a services polling module, but still polls through the separate check-services.php or lnms services:poll scripts by default.
Attempts to parse help text into valid options.
Default values for options such as -H.
TODO:
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.