Add battery operating time for APC UPS devices

[mwobst]

PLEASE NOTE: This pull request leads to a failing test because the difference mentioned below is calculated by using the current date. Thus the difference in the file tests/data/apc_managementmoduleaosv6.8.8-appv6.8.8.json will always be wrong after at least one day has passed after the last commit. This somewhat seems to be a flaw within the test framework (or so I suppose).

Description:
With this feature, the date of last battery change is determined and used for building the difference to today. That difference is stored as minutes and displayed as years + minutes as »Battery Operating Time«. The limits are 4 years (warning/yellow) and 5 years (critical/red) – values from our own experience.

Time display in GUI (device main page):

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

• Have you followed our code guidelines?
• If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
• If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

[CLAassistant]

All committers have signed the CLA.

[mwobst]

As expected, the tests will fail. Is there any recommendation how to proceed. I could revert to a draft requested but I don’t think this would really help …

For people not involved: There was a similar pull request that also had been approved and merged, but lead to this failing tests and was thus reverted. The feature though is not only required by us, it also raised interest by other users.

[Jellyfrog]

1. Could you implement this in yaml instead? You need to add a custom function to do the conversion (called user_func in yaml)
   You can add a function to LibreNMS\Util\Time.php, and call it like user_func: \LibreNMS\Util\Time:name-it-something-generic-and-good

2. You have to manually fix the failing json file (check the test output for what to change)

[mwobst]

1. Could you implement this in yaml instead? You need to add a custom function to do the conversion (called user_func in yaml)
   You can add a function to LibreNMS\Util\Time.php, and call it like user_func: \LibreNMS\Util\Time:name-it-something-generic-and-good

I am not exactly deep into the topic, so I have to ask some questions: Which file do you mean with "instead" … and is there any other example which I can use for orientation?

2. You have to manually fix the failing json file (check the test output for what to change)

Test output? When and where do I see it?
(Please bear with me as I am working on several other (and different) things at work …)

[murrant]

1. includes/definitions/discovery/apc.yaml
2. at the bottom by the X's go to the right and click details (wait a second for it to scroll)