Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SnmpResponse filterBadLines fix #14306

Merged
merged 1 commit into from Sep 6, 2022

Conversation

murrant
Copy link
Member

@murrant murrant commented Sep 5, 2022

Actually filter lines (instead of full responses) with No Such Instance regex

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Actually filter lines (instead of full responses) with No Such Instance regex
@Jellyfrog
Copy link
Member

Fun find

@Jellyfrog Jellyfrog merged commit 69d1c20 into librenms:master Sep 6, 2022
@murrant murrant deleted the snmpresponse-filter-lines branch September 6, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants