Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow sysDescr to be fetched in os module yaml #14331

Merged
merged 1 commit into from Sep 9, 2022

Conversation

murrant
Copy link
Member

@murrant murrant commented Sep 9, 2022

It has already been fetched, use sysDescr_regex

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

It has already been fetched, use sysDescr_regex
@murrant murrant added the Tests 🧪 Test for Code label Sep 9, 2022
@murrant murrant merged commit 6b1ae1d into librenms:master Sep 9, 2022
@murrant murrant deleted the os-yaml-sysDescr branch September 9, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests 🧪 Test for Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant