Openmanage enterprise modular #14408
Conversation
|
|
Jellyfrog
added
Device 🖥️
|
missing json part of the test data |
|
Please add test data so we can ensure your change is not broken in the future. |
|
Nice work! Are you sure it's the right OID for idle Power? On your screenshot it's more than Max Power wich seems to be wrong. |
|
I believe it ends up being the power still available to the system, but is the documented oid in the most recent docs I can find. |
|
Ah THX for the Link. As I understand, dmmPowerWattsPeakUsage is just for the chassis and dmmPowerIdlePower also includes the the powered on Servers. Can we add something to the descr. That the sensor value is more clear for the rest? |
|
Is there a way to do mouse over extra descriptions for sensors? That would be neat. I think I was trying to keep similar naming to the drac cmc stuff that already exists for the M1000e chassis, but perhaps some better names could be used. From what I can tell it is: dmmPowerIdlePower: Idle power still available |
|
Interesting Idea! Actually I think we do not have a field which we could use to show for a mouse over extra descr. But LNMS is a community driven project. If you make a PR it will come to the project. I would like it! I for myself would do some little changes but this is just my opinion and you should decide... Then I would rename the Power Descr. I like this As last step I would think about the use of Power min and max. I would put the two values to the Chasis1 (current) sensor as Min and Max warn limits and not as seperate sensors. |
Remove commented out dmmGlobalSystemStatus num_oid Change Max/Min Power to Peak/Min Usage
|
I changed Max/Min Power to Peak/Min Usage, which hopefully makes more sense, and is more inline with the older M1000e chassis graphs. I prefer to keep names as close as possible to the older chassis so people can reuse any pattern matching for alerts or dashboards or whatever. Those OIDs aren't useful as limits as they aren't static values they are something that is a point in time measurement and will change. Looks like idle power is a bit weird on the older chassis too, perhaps I will open a ticket with dell to fix those. Anyways, I have no luck with creating json files and I'm not sure what magic @PipoCanaja did in my other ticket to create that, but would appreciate any assistance in making one for this too. -bash-4.2$ ./scripts/save-test-data.php -o dell-ome-m -v dell-ome-m Failed to start Snmpsim. Scroll up for error.
|
|
Hi @jgelinas @Jellyfrog Any idea of what's going wrong and how to fix it ? |
|
No idea sorry |
if you installed snmpd from a package manager, remove it and install via pip |
|
I grabbed the VM image and got snmpsim to produce the json from that. |
|
@jgelinas you need to fix the broken tests. Try deleting the json file and regenerate it |
|
@Jellyfrog I've regenerated the snmprec and json files, but still get failures. |
|
I was thinking about this a bit, could this be failing because the enclosure has failover interfaces? The json looks like it might be doubled up on the ports with some having data and some not, presumably because it has never had the need to failover? |
|
Something in @jgelinas dev environment did not match the test environment. |
* Add support for OpenManage Modular devices. * Update dell-ome-m.yaml Remove commented out dmmGlobalSystemStatus num_oid Change Max/Min Power to Peak/Min Usage * json test file for open manage modular support * Update dell-ome-m_dell-ome-m.json * Update dell-ome-m_dell-ome-m.snmprec * Update dell-ome-m_dell-ome-m.json * Update dell-ome-m_dell-ome-m.snmprec * Update dell-ome-m_dell-ome-m.json --------- Co-authored-by: Tony Murray <murraytony@gmail.com>
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
* Add support for OpenManage Modular devices. * Update dell-ome-m.yaml Remove commented out dmmGlobalSystemStatus num_oid Change Max/Min Power to Peak/Min Usage * json test file for open manage modular support * Update dell-ome-m_dell-ome-m.json * Update dell-ome-m_dell-ome-m.snmprec * Update dell-ome-m_dell-ome-m.json * Update dell-ome-m_dell-ome-m.snmprec * Update dell-ome-m_dell-ome-m.json --------- Co-authored-by: Tony Murray <murraytony@gmail.com>
Add support for Dell OpenMange Enterprise Modular currently used in the MX7000 blade chassis.
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.