Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and improve snmptranslate usage #14567

Merged
merged 20 commits into from Nov 7, 2022

Conversation

murrant
Copy link
Member

@murrant murrant commented Nov 3, 2022

Please give a short description what your pull request is for

DO NOT DELETE THE UNDERLYING TEXT

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the Cleanup label Nov 3, 2022
@murrant murrant closed this Nov 3, 2022
@murrant murrant reopened this Nov 3, 2022
@murrant murrant force-pushed the better-translate branch 2 times, most recently from 21e2c86 to 7260510 Compare November 5, 2022 15:58
includes/snmp.inc.php Outdated Show resolved Hide resolved
@murrant murrant merged commit 0801af7 into librenms:master Nov 7, 2022
@murrant murrant deleted the better-translate branch November 7, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants