Adding support for loop-telecom devices #14674
Conversation
|
|
|
Mark it as a draft pr instead |
Jellyfrog
changed the title
| @@ -0,0 +1,13 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Hi,
You can probably do it in YAML and provide snmp_hexstring as user-func.
There was a problem hiding this comment.
Could you provide me with an example on how to do this?
I could not find this anywhere in the documentation.
Thank you!
|
Hi |
|
@Jellyfrog any idea why the |
| mib: L-AM3440-A-Private | ||
| modules: | ||
| os: | ||
| hardware: SNMPv2-MIB::sysObjectID.0 |
There was a problem hiding this comment.
Delete this line and set hardware_mib: L-AM3440-A-Private instead.
There was a problem hiding this comment.
| break; | ||
| } | ||
| //Set port mode | ||
| switch ($port['ethernetStatusMode']) { |
There was a problem hiding this comment.
These are not valid ifType values. See IANAifType-MIB
There was a problem hiding this comment.
This has now been replaced by setting the ports to ethernetCsmacd. Is there any way to specify physical port type?
There was a problem hiding this comment.
That would probably be in inventory (usually supplied by ENTITY-MIB)
|
FYI, I merged #14699 which will handle whitespace in front of the number. |
ghost
marked this pull request as ready for review
ghost
requested review from
murrant and
PipoCanaja
and removed request for
murrant
|
@murrant @PipoCanaja any thing else needed to merge the pull request? |
Jellyfrog
added
the
Needs Tests 🦄
|
Missing json test data |
|
Please add test data so we can ensure your change is not broken in the future. |
Json test data has now been added :) |
Jellyfrog
removed
the
Needs Tests 🦄
|
There is no other name for the operating system? (librenms works with OSes rather than vendors) |
Unfortunately not. I have not found any mentioning of the OS name anywhere in the device or other devices I have used from the same vendor the last 5 years. Therefor I assume they use the same OS on all devices. |
|
Good job here! |
|
This pull request has been mentioned on LibreNMS Community. There might be relevant details there: |
Adding support for telecom products from Loop-Telecom.
Hardware setup:
What's working
What's not working
Collecting packet count and graphing port traffic (think I'm collecting the data correctly. Do i have to I have to define that I want to create graphs for each port?)States for PSU and line cards stops working after the poller run for the first time. If I delete and add the device again the states are working again. Looks the the{{$index}}for the linecars num_oid reports the slot name insted of slot number. Not sure if i can fix this in the yaml file or if I have to do the integration with php instead.Hardware name includes the name of the mib ( L-AM3440-A-Private::loop-AM3440-CCPB-A. should be just "loop-AM3440-CCPB-A")Problems saving test dataDO NOT DELETE THE UNDERLYING TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>, i.e./scripts/github-apply 5926After you are done testing, you can remove the changes with
./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.