Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add liebert detailsv2 #14746

Merged
merged 6 commits into from Nov 4, 2023
Merged

Add liebert detailsv2 #14746

merged 6 commits into from Nov 4, 2023

Conversation

RandGH
Copy link
Contributor

@RandGH RandGH commented Dec 20, 2022

Please give a short description what your pull request is for

Adding per reception details for Liebert /Vertiv PDUs
Re-created pull to fix abbreviated labels

Please note

Please read this information carefully. You can run ./lnms dev:check to check your code before submitting.

  • Have you followed our code guidelines?
  • If my Pull Request does some changes/fixes/enhancements in the WebUI, I have inserted a screenshot of it.
  • If my Pull Request makes discovery/polling/yaml changes, I have added/updated test data.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@Jellyfrog Jellyfrog added Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/ labels Dec 21, 2022
@github-actions
Copy link

Please add test data so we can ensure your change is not broken in the future.
Read the docs to find out how: https://docs.librenms.org/Developing/os/Test-Units

@murrant murrant merged commit 6534c8e into librenms:master Nov 4, 2023
8 checks passed
@librenms-bot
Copy link

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/23-11-0-changelog/22833/1

gdepeyrot pushed a commit to gdepeyrot/librenms that referenced this pull request Nov 29, 2023
* Restored abbreviated item labels

* Added receptions details on Liebert MPH pdus (non abbreviated)

* Fix whitespace

* Create liebert_mph2rg.json

* Update liebert.json

* Update liebert_mph2rg.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
gunkaaa pushed a commit to gunkaaa/librenms that referenced this pull request Jan 8, 2024
* Restored abbreviated item labels

* Added receptions details on Liebert MPH pdus (non abbreviated)

* Fix whitespace

* Create liebert_mph2rg.json

* Update liebert.json

* Update liebert_mph2rg.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
@RandGH RandGH deleted the add-liebert-detailsv2 branch March 21, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Device 🖥️ New or added device support Needs Tests 🦄 https://docs.librenms.org/Developing/os/Test-Units/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants